Thunderbird Extensions
Apple - mac
Donation
Make a donation to help WiPhA development

Search




Preferences

Connect again
---

Your user name :

Your secret code


 Count of members 126 members


Connected :

(nobody)
Visits

 2645897 visitors

 17 visitors online

Private
forum.gifForum - External Editor - Topic #364

Forum - Forum
External Editor - External Editor


active  Topic # 364  Stopped working with TB 52.0

07/04/2017 @ 00:45
by eliotmoss

Anonymous

visitor

External Editor seems no longer to work properly under Thunderbird 52.0.  I am running Windows 10 Anniversary Edition.  The extension has worked fine for me for years, and just now broke - the editor did not come up, and when I try to edit the options, I see that the editor file name is blank, and I can't fix it because the OK button for the options dialog does not operate (does nothing; options panel remains open).  I could not figure out how / where to edit the supporting files manually, so for now I can't do external editing ...

Regards - Eliot Moss
  Post an answer  Top

[]   

Answer n 1
--------
07/04/2017 @ 09:25
by stephendowdy

Anonymous

visitor
I was sad, too confused   There are probably not many of us still/ever using this.

I extracted the XPI and while i'm not quite sure what's going on, it's related to the nsIPref*() calls, i believe here:

../chrome/content/exteditor.js:  prefNotifierExe                      = nsPreferences.copyUnicharPref('exteditor.default.editor', "");
(Ha, documentation for this is pathetic, but it seems this changed when "nsIPref" was replaced by "nsIPrefBranch".  Also, i presume that nsPreferences is inherited by thunderbird extensions, because i don't see it being assigned in the XPI anywhere, only referenced.)

I tried changing that to '.getCharPref(...)' to no avail.
So, right now, i have a hardcode to the script i use to perform edits via gvim :

// SDOWDY HARDCODED
prefNotifierExe="/home/sdowdy/bin/tb-ee-gvim";
    extEditorRunProgram(prefNotifierExe, params, editorObserver); // non blocking call

IT WORKS FOR ME(TM)   for now, but i'm not thrilled with it.   If i figure it out (i'm a sysadmin, not a mozilla developer...) , i'll try to post back.
Write to stephendowdy   Post an answer  Top
Answer n 2
--------
07/04/2017 @ 11:38
by eliotmoss

Anonymous

visitor
Well, I've tried that editing, and it is always possible I did not get it quite right (not least because of Windows filename syntax and \ quoting) but it acts as before - the editor window never comes up and there is no way to exit TB - I have to kill it from the Task Manager.  So I feel stuck ... sigh.  Thank you for trying!   Eliot
  Post an answer  Top
Answer n 3
--------
08/04/2017 @ 04:11
by stephendowdy

Anonymous

visitor
Eliot,

On linux, if i click the CLOSE button on the compose window, it throws a message handled by ExtEditor "Please Close all External Editor windows..." (or such).

However, if i use "File->Close", the window will close (and the main thunderbird window remains open, so it's just a sub-window close, not an application exit.

--stephen
Write to stephendowdy   Post an answer  Top
Answer n 4
--------
09/04/2017 @ 10:12
by eliotmoss

Anonymous

visitor
Thank you, Stephen.  I think I later discovered that.  Still wish I could get the extension working, though.  Regards - EM
  Post an answer  Top
Answer n 5
--------
11/04/2017 @ 15:32
by psz

Anonymous

visitor
Same problem here: does not work with Thunderbird 52.0, on
Debian Linux. At home I have Ubuntu and there use the "packaged"
Thunderbird, they will update shortly then I can test that also.
(Just adding my voice as a previously satisfied user.)
Anything I can do to help? Other than attempting to come up with
yet another clone...
Write to psz   Post an answer  Top
Answer n 6
--------
11/04/2017 @ 22:01
by snipsnipsnip

Anonymous

visitor
Hi, I made a tweak and it seems like working.

Binary: https://github.com/snipsnipsnip/exteditor/releases/download/v1.0.1-unofficial/exteditor_tb52_v101.xpi

Patch: https://github.com/snipsnipsnip/exteditor/commit/4d0f836e4c5b8695df3d59427bd212de234de246
  Post an answer  Top
Answer n 7
--------
11/04/2017 @ 22:17
by eliotmoss

Anonymous

visitor
Yay!  This patch also works for me!  It is possible that the reason the previous solution did not work for me is that my external editor (XEmacs running under Windows 10) needed additional flags to start right.  This was something I had figured out ages ago, and did not remember confused ... but the patch brought back the preferences and showed that setting.  In fact, I did not need to change anything, just use the patched version.  Thank you all for your help restoring this to working order!   Eliot Moss
  Post an answer  Top
Answer n 8
--------
12/04/2017 @ 06:09
by psz

Anonymous

visitor
Thanks for the exteditor_tb52_v101 patch: works perfectly for me
(Debian Linux).
Write to psz   Post an answer  Top
Answer n 9
--------
15/04/2017 @ 21:46
by el

Anonymous

visitor
Works on TB 52.0.1 on MacOs 10.12.4

Thanks, el
  Post an answer  Top
Answer n 10
--------
16/05/2017 @ 22:52
by sltls

Anonymous

visitor
Thank you so much for the fix - its working flawlessly again !! 'Would gladly pay for longtime external editor support in Thunderbird. I don't want to stop using emacs for emails, but cannot for the life of me maintain a working vm or wanderlust setup. e
  Post an answer  Top
Answer n 11
--------
25/05/2017 @ 15:46
by AHM

AHM


Thanks very much for the edit!
Removing V1.0.0 and installing V1.0.1-unofficial fixed the problem on TB 52.1.1 (32-bit).

I hope the maxVersion of 52 in install.rdf doesn't force us to keep hacking our installations with every major TB release.  If that is just a conservative value, perhaps you will be emboldened to lift the upper bound after you think there's enough field testing on TB 52.
  Post an answer  Top
Answer n 12
--------
26/05/2017 @ 03:47
by Tobiah

Anonymous

visitor
Thanks for that, it works!

You rock.
  Post an answer  Top
Answer n 13
--------
31/05/2017 @ 02:35
by Rolf

Anonymous

visitor
Thanks, snipsnipsnip!!! I had the same problem but now with
tb52_v101.xpi everything is fine again.
  Post an answer  Top
Answer n 14
--------
29/11/2017 @ 18:30
by Saibot

Anonymous

visitor
Thanks +1, made my day!!
  Post an answer  Top
Answer n 15
--------
29/11/2017 @ 23:59
by globs

globs


Latest official versions will now be found at https://github.com/exteditor/exteditor/releases
Rectified by globs 29/11/2017 @ 17:00
Write to globs   Website globs Post an answer  Top
active topic active   closed topic closed   Sticky Sticky   New New message   -   Correct Correct message   Close Close topic   Make sticky Make sticky
[]
Forum Topic  Forum 



^ Top ^