Don
Faire un don pour aider au developpement de WiPhA

Recherche




Préférences

Se reconnecter
---

Votre nom (ou pseudo) :

Votre code secret


 Nombre de membres 126 membres


Connectés :

( personne )
Visites

 2340119 visiteurs

 29 visiteurs en ligne

forum.gifForum - External Editor - Sujet n°364

Forum - Forum
External Editor - External Editor


actif  Sujet n° 364  Stopped working with TB 52.0

le 07/04/2017 @ 00:45
par eliotmoss

Anonyme

visiteur

External Editor seems no longer to work properly under Thunderbird 52.0.  I am running Windows 10 Anniversary Edition.  The extension has worked fine for me for years, and just now broke - the editor did not come up, and when I try to edit the options, I see that the editor file name is blank, and I can't fix it because the OK button for the options dialog does not operate (does nothing; options panel remains open).  I could not figure out how / where to edit the supporting files manually, so for now I can't do external editing ...

Regards - Eliot Moss
  Poster une réponse  Haut

[]   

Réponse n° 1
--------
le 07/04/2017 @ 09:25
par stephendowdy

Anonyme

visiteur
I was sad, too confused   There are probably not many of us still/ever using this.

I extracted the XPI and while i'm not quite sure what's going on, it's related to the nsIPref*() calls, i believe here:

../chrome/content/exteditor.js:  prefNotifierExe                      = nsPreferences.copyUnicharPref('exteditor.default.editor', "");
(Ha, documentation for this is pathetic, but it seems this changed when "nsIPref" was replaced by "nsIPrefBranch".  Also, i presume that nsPreferences is inherited by thunderbird extensions, because i don't see it being assigned in the XPI anywhere, only referenced.)

I tried changing that to '.getCharPref(...)' to no avail.
So, right now, i have a hardcode to the script i use to perform edits via gvim :

// SDOWDY HARDCODED
prefNotifierExe="/home/sdowdy/bin/tb-ee-gvim";
    extEditorRunProgram(prefNotifierExe, params, editorObserver); // non blocking call

IT WORKS FOR ME(TM)   for now, but i'm not thrilled with it.   If i figure it out (i'm a sysadmin, not a mozilla developer...) , i'll try to post back.
Ecrire à stephendowdy   Poster une réponse  Haut
Réponse n° 2
--------
le 07/04/2017 @ 11:38
par eliotmoss

Anonyme

visiteur
Well, I've tried that editing, and it is always possible I did not get it quite right (not least because of Windows filename syntax and \ quoting) but it acts as before - the editor window never comes up and there is no way to exit TB - I have to kill it from the Task Manager.  So I feel stuck ... sigh.  Thank you for trying!   Eliot
  Poster une réponse  Haut
Réponse n° 3
--------
le 08/04/2017 @ 04:11
par stephendowdy

Anonyme

visiteur
Eliot,

On linux, if i click the CLOSE button on the compose window, it throws a message handled by ExtEditor "Please Close all External Editor windows..." (or such).

However, if i use "File->Close", the window will close (and the main thunderbird window remains open, so it's just a sub-window close, not an application exit.

--stephen
Ecrire à stephendowdy   Poster une réponse  Haut
Réponse n° 4
--------
le 09/04/2017 @ 10:12
par eliotmoss

Anonyme

visiteur
Thank you, Stephen.  I think I later discovered that.  Still wish I could get the extension working, though.  Regards - EM
  Poster une réponse  Haut
Réponse n° 5
--------
le 11/04/2017 @ 15:32
par psz

Anonyme

visiteur
Same problem here: does not work with Thunderbird 52.0, on
Debian Linux. At home I have Ubuntu and there use the "packaged"
Thunderbird, they will update shortly then I can test that also.
(Just adding my voice as a previously satisfied user.)
Anything I can do to help? Other than attempting to come up with
yet another clone...
Ecrire à psz   Poster une réponse  Haut
Réponse n° 6
--------
le 11/04/2017 @ 22:01
par snipsnipsnip

Anonyme

visiteur
Hi, I made a tweak and it seems like working.

Binary: https://github.com/snipsnipsnip/exteditor/releases/download/v1.0.1-unofficial/exteditor_tb52_v101.xpi

Patch: https://github.com/snipsnipsnip/exteditor/commit/4d0f836e4c5b8695df3d59427bd212de234de246
  Poster une réponse  Haut
Réponse n° 7
--------
le 11/04/2017 @ 22:17
par eliotmoss

Anonyme

visiteur
Yay!  This patch also works for me!  It is possible that the reason the previous solution did not work for me is that my external editor (XEmacs running under Windows 10) needed additional flags to start right.  This was something I had figured out ages ago, and did not remember confused ... but the patch brought back the preferences and showed that setting.  In fact, I did not need to change anything, just use the patched version.  Thank you all for your help restoring this to working order!   Eliot Moss
  Poster une réponse  Haut
Réponse n° 8
--------
le 12/04/2017 @ 06:09
par psz

Anonyme

visiteur
Thanks for the exteditor_tb52_v101 patch: works perfectly for me
(Debian Linux).
Ecrire à psz   Poster une réponse  Haut
Réponse n° 9
--------
le 15/04/2017 @ 21:46
par el

Anonyme

visiteur
Works on TB 52.0.1 on MacOs 10.12.4

Thanks, el
  Poster une réponse  Haut
Réponse n° 10
--------
le 16/05/2017 @ 22:52
par sltls

Anonyme

visiteur
Thank you so much for the fix - its working flawlessly again !! 'Would gladly pay for longtime external editor support in Thunderbird. I don't want to stop using emacs for emails, but cannot for the life of me maintain a working vm or wanderlust setup. e
  Poster une réponse  Haut
Réponse n° 11
--------
le 25/05/2017 @ 15:46
par AHM

AHM


Thanks very much for the edit!
Removing V1.0.0 and installing V1.0.1-unofficial fixed the problem on TB 52.1.1 (32-bit).

I hope the maxVersion of 52 in install.rdf doesn't force us to keep hacking our installations with every major TB release.  If that is just a conservative value, perhaps you will be emboldened to lift the upper bound after you think there's enough field testing on TB 52.
  Poster une réponse  Haut
Réponse n° 12
--------
le 26/05/2017 @ 03:47
par Tobiah

Anonyme

visiteur
Thanks for that, it works!

You rock.
  Poster une réponse  Haut
Réponse n° 13
--------
le 31/05/2017 @ 02:35
par Rolf

Anonyme

visiteur
Thanks, snipsnipsnip!!! I had the same problem but now with
tb52_v101.xpi everything is fine again.
  Poster une réponse  Haut
actif sujet actif   clos sujet clos   Important! Important!   Nouveau Nouveau message   -   Rectifier Rectifier message   Clôturer Clôturer sujet   Remonter Remonter
[]
Catégories de discussion  Forum 



^ Haut ^